From 44c30161becdb77ba275a38fb452580126bf290d Mon Sep 17 00:00:00 2001
From: Krzysztof Kiewicz <krzysztof@quesma.com>
Date: Thu, 26 Dec 2024 22:30:56 +0100
Subject: [PATCH] Cleanup

---
 quesma/model/expr_string_renderer.go        | 9 ++++-----
 quesma/model/query.go                       | 4 ++--
 quesma/queryparser/query_translator_test.go | 2 +-
 quesma/quesma/schema_transformer.go         | 6 +++---
 4 files changed, 10 insertions(+), 11 deletions(-)

diff --git a/quesma/model/expr_string_renderer.go b/quesma/model/expr_string_renderer.go
index cc9f57e89..0c0424019 100644
--- a/quesma/model/expr_string_renderer.go
+++ b/quesma/model/expr_string_renderer.go
@@ -3,7 +3,6 @@
 package model
 
 import (
-	"context"
 	"fmt"
 	"quesma/logger"
 	"quesma/quesma/types"
@@ -71,18 +70,18 @@ func (v *renderer) VisitLiteral(l LiteralExpr) interface{} {
 }
 
 func (v *renderer) VisitTuple(t TupleExpr) interface{} {
-	exprs := make([]string, 0)
+	exprs := make([]string, 0, len(t.Exprs))
 	for _, expr := range t.Exprs {
 		exprs = append(exprs, expr.Accept(v).(string))
 	}
 	switch len(exprs) {
 	case 0:
-		logger.WarnWithCtxAndThrottling(context.Background(), "visit", "tuple", "tuple with 0 length") // hacky way to log this
+		logger.WarnWithThrottling("visitTuple", "tupleExpr with no expressions") // hacky way to log this
 		return "tuple()"
 	case 1:
-		return exprs[0]
+		return t.Exprs[0]
 	default:
-		return fmt.Sprintf("tuple(%s)", strings.Join(exprs, ", "))
+		return fmt.Sprintf("tuple(%s)", strings.Join(exprs, ", ")) // can omit "tuple", but I think SQL's more readable with it
 	}
 }
 
diff --git a/quesma/model/query.go b/quesma/model/query.go
index a1163151c..767536dcc 100644
--- a/quesma/model/query.go
+++ b/quesma/model/query.go
@@ -64,7 +64,7 @@ type (
 		Schema schema.Schema
 
 		Highlighter Highlighter
-		SearchAfter any // value of query's "search_after" param. Used for pagination of hits. SearchAfterEmpty means no pagination
+		SearchAfter any // Value of query's "search_after" param. Used for pagination of hits. SearchAfterEmpty means no pagination
 
 		RuntimeMappings map[string]RuntimeMapping
 
@@ -162,7 +162,7 @@ type HitsCountInfo struct {
 	RequestedFields []string
 	Size            int // how many hits to return
 	TrackTotalHits  int // >= 0: we want this nr of total hits, TrackTotalHitsTrue: it was "true", TrackTotalHitsFalse: it was "false", in the request
-	SearchAfter     any // used for pagination of hits. EmptySearchAfter means no pagination
+	SearchAfter     any // Value of query's "search_after" param. Used for pagination of hits. SearchAfterEmpty means no pagination
 }
 
 func NewEmptyHitsCountInfo() HitsCountInfo {
diff --git a/quesma/queryparser/query_translator_test.go b/quesma/queryparser/query_translator_test.go
index 631f9fad4..9a9a9fd0a 100644
--- a/quesma/queryparser/query_translator_test.go
+++ b/quesma/queryparser/query_translator_test.go
@@ -182,7 +182,7 @@ func TestMakeResponseSearchQuery(t *testing.T) {
 		t.Run(tt.queryType.String(), func(t *testing.T) {
 			hitQuery := query_util.BuildHitsQuery(
 				context.Background(), "test", []string{"*"},
-				&model.SimpleQuery{}, model.WeNeedUnlimitedCount, nil,
+				&model.SimpleQuery{}, model.WeNeedUnlimitedCount, model.SearchAfterEmpty,
 			)
 			highlighter := NewEmptyHighlighter()
 			queryType := typical_queries.NewHits(cw.Ctx, cw.Table, &highlighter, hitQuery.SelectCommand.OrderByFieldNames(), true, false, false, []string{cw.Table.Name})
diff --git a/quesma/quesma/schema_transformer.go b/quesma/quesma/schema_transformer.go
index c7ac98705..67c449419 100644
--- a/quesma/quesma/schema_transformer.go
+++ b/quesma/quesma/schema_transformer.go
@@ -21,11 +21,11 @@ type SchemaCheckPass struct {
 	searchAfterStrategy searchAfterStrategy
 }
 
-func NewSchemaCheckPass(cfg *config.QuesmaConfiguration, tableDiscovery clickhouse.TableDiscovery, searchAfterStrategy searchAfterStrategyType) *SchemaCheckPass {
+func NewSchemaCheckPass(cfg *config.QuesmaConfiguration, tableDiscovery clickhouse.TableDiscovery, strategyType searchAfterStrategyType) *SchemaCheckPass {
 	return &SchemaCheckPass{
 		cfg:                 cfg,
 		tableDiscovery:      tableDiscovery,
-		searchAfterStrategy: searchAfterStrategyFactory(searchAfterStrategy),
+		searchAfterStrategy: searchAfterStrategyFactory(strategyType),
 	}
 }
 
@@ -890,6 +890,7 @@ func (s *SchemaCheckPass) applyAliasColumns(indexSchema schema.Schema, query *mo
 }
 
 func (s *SchemaCheckPass) Transform(queries []*model.Query) ([]*model.Query, error) {
+
 	transformationChain := []struct {
 		TransformationName string
 		Transformation     func(schema.Schema, *model.Query) (*model.Query, error)
@@ -941,7 +942,6 @@ func (s *SchemaCheckPass) Transform(queries []*model.Query) ([]*model.Query, err
 
 			query, err = transformation.Transformation(query.Schema, query)
 			if err != nil {
-				fmt.Println("SchemaCheckPass.Transform", err)
 				return nil, err
 			}