Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Elasticsearch-based async storage #7

Open
jakozaur opened this issue Apr 11, 2024 · 1 comment
Open

Implement Elasticsearch-based async storage #7

jakozaur opened this issue Apr 11, 2024 · 1 comment
Assignees
@jakozaur @trzysiek

Comments

@jakozaur
Copy link
Contributor

Currently:

  • we don't respect the async storage policy
  • we have no way of offloading results out of memory

We should implement that.
@pivovarit pivovarit transferred this issue from another repository May 2, 2024
@mieciu mieciu changed the title Make sure async storage works correctly Implement Elasticsearch-based async storage Nov 20, 2024
@mieciu
Copy link
Member

mieciu commented Nov 20, 2024 •
edited
Loading

Effort started by @trzysiek (https://github.com/QuesmaOrg/quesma/pull/895/files and few others).

One thing that caught my attention is that we currently have two separate structs: AsyncRequestStorage and AsyncQueriesContexts:

quesma/quesma/quesma/search.go

Lines 45 to 48 in d36b617

cancel context.CancelFunc
AsyncRequestStorage async_search_storage.AsyncRequestResultStorage
AsyncQueriesContexts async_search_storage.AsyncQueryContextStorage
logManager *clickhouse.LogManager

Perhaps we could look at simplifying this and use one storage for both? 🤔
(just a suggestion, perhaps there are valid concerns against doing so)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakozaur jakozaur

@trzysiek trzysiek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jakozaur @mieciu @trzysiek