Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove filters limitations #944

Open
jakozaur opened this issue Nov 1, 2024 · 0 comments
Open

Remove filters limitations #944

jakozaur opened this issue Nov 1, 2024 · 0 comments

Comments

@jakozaur
Copy link
Contributor

jakozaur commented Nov 1, 2024

We allow filters only as top or as leaf bucket aggregations. We also might return undercount if we have top-level filters.

We should allow them everywhere.

See:
#927
@trzysiek trzysiek mentioned this issue Nov 11, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Nov 21, 2024
@trzysiek
Improve (date)_range just like filters (#970)
2e78116 
Don't get dissuaded by the nr of changed lines, there's almost nothing
happening here.

`(Date)_range` and `filters` are basically the same aggregation. I
recently improved `filters` a bit, but didn't do anything to
`(date)_range`.
This PR makes all those combinators work in the same way, so there are
two issues left - #971
(easier) and #944 (a bit
harder). Afterwards they will all fully work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jakozaur