Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quickfix: bool column with terms aggr #1145

Merged
merged 6 commits into from
Dec 28, 2024
Merged

Quickfix: bool column with terms aggr #1145

merged 6 commits into from
Dec 28, 2024

Conversation

trzysiek
Copy link
Member

@trzysiek trzysiek commented Dec 28, 2024 •
edited
Loading

Response for a bool bucket needs to be slightly different.

Before:
Screenshot 2024-12-28 at 15 42 21
After:
Screenshot 2024-12-28 at 15 17 41

@trzysiek trzysiek force-pushed the terms-bool branch 4 times, most recently from f06d982 to c564b0c Compare December 28, 2024 14:40
@trzysiek trzysiek marked this pull request as ready for review December 28, 2024 14:47
@trzysiek trzysiek requested a review from a team as a code owner December 28, 2024 14:47
@jakozaur jakozaur added this pull request to the merge queue Dec 28, 2024
Merged via the queue into main with commit d4745d3 Dec 28, 2024
5 checks passed
@jakozaur jakozaur deleted the terms-bool branch December 28, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakozaur jakozaur jakozaur approved these changes

@nablaone nablaone Awaiting requested review from nablaone nablaone is a code owner automatically assigned from QuesmaOrg/engineering

@mieciu mieciu Awaiting requested review from mieciu mieciu is a code owner automatically assigned from QuesmaOrg/engineering

@avelanarius avelanarius Awaiting requested review from avelanarius avelanarius is a code owner automatically assigned from QuesmaOrg/engineering

@pdelewski pdelewski Awaiting requested review from pdelewski pdelewski is a code owner automatically assigned from QuesmaOrg/engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trzysiek @jakozaur