-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example for Combine #8
Comments
It would definitely be great to provide an example app with Combine instead of RxSwift. However, due to time constraints, I cannot really work on it at the moment - feel free to open a MR yourself though! 😊 |
Do you have any preference how this should be structured? Adding Maybe splitting the project into two targets and having a shared code base. As far as I see it right now the Model and the Impl files are effected by this since |
I'm not quite sure, whether mixing the two makes much sense, since it might overcomplicate things... A shared code base with different targets is also somewhat difficult since it would require too many changes or unfamiliar code (i.e. typealias instead of actual name or separate files altogether without much actually shared code). I would suggest doing the Combine version on a special branch and then cross-referencing the Combine and master branch. |
Finished the rewrite. It's more or less a direct translation from one Framework to the other and certainly could be more "Combinely" (if thats a word). |
Is it planned to make the example using Combine instead of RxSwift?
Man it sounds like I‘m an opponent of RxSwift xD
The text was updated successfully, but these errors were encountered: