Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pip install is unpredictable and often breaks #7

Closed
sdenton4 opened this issue Mar 1, 2024 · 1 comment
Closed

Pip install is unpredictable and often breaks #7

sdenton4 opened this issue Mar 1, 2024 · 1 comment

Comments

@sdenton4
Copy link
Collaborator

sdenton4 commented Mar 1, 2024

I discovered that pip install doesn't actually make use of the poetry lock file, and essentially makes up the dependency tree on the fly from the pyproject.toml file.... This means that it's pretty easy to get into a weird state when we do the colab pip install: the lock file gives us a specific tested combination of dependency versions, with CI tests, but we don't have any real way to test what's going on with the pip-installed version.

Ideally, we should have pip install the exact set of dependency versions specified in the lock file, to ensure that our CI testing actually tells us that the Colab notebooks are working.

There's some pretty extensive discussion here of the problem:
python-poetry/poetry#2778 (comment)

@sdenton4
Copy link
Collaborator Author

sdenton4 commented Mar 1, 2024

Derp, just opened this issue on our main branch here:
google-research/perch#620

@sdenton4 sdenton4 closed this as completed Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant