Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken language hooks #797

Closed
GeckoEidechse opened this issue Aug 31, 2024 · 2 comments
Closed

Broken language hooks #797

GeckoEidechse opened this issue Aug 31, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@GeckoEidechse
Copy link
Member

As discovered in #787 (comment) the language hooks utilising -language appear to not work at all.

This was the case even before the PR the comment was made on. It's unclear for how long they have been broken or what change caused them to break (or if they even worked in the first place lol).

@GeckoEidechse GeckoEidechse added the bug Something isn't working label Aug 31, 2024
@GeckoEidechse GeckoEidechse changed the title Fix broken language hooks Broken language hooks Aug 31, 2024
@Gazyi
Copy link
Contributor

Gazyi commented Sep 8, 2024

In #787 (comment) both commands have typos.
Origin version, added -language polish in ns_startup_args. I don't see any problems.
[2024-09-08] [09:52:46] [NORTHSTAR] [info] User forcing the language (-language) to: polish
snapshot0000

@GeckoEidechse
Copy link
Member Author

In #787 (comment) both commands have typos.
Origin version, added -language polish in ns_startup_args. I don't see any problems.

Omfg, how did neither me nor anyone else looking at the PR notice this x_x

Anyway, thanks for testing <3

I'm closing this issue as skill issue on my end xD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants