Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running ramp from .py file doesn't have nice date support yet #58

Open
Bachibouzouk opened this issue Jan 26, 2023 · 2 comments · Fixed by #102
Open

Running ramp from .py file doesn't have nice date support yet #58

Bachibouzouk opened this issue Jan 26, 2023 · 2 comments · Fixed by #102
Labels
enhancement New feature or request

Comments

@Bachibouzouk
Copy link
Collaborator

Bachibouzouk commented Jan 26, 2023

I was wondering if the same [date input] feature can be implemented in ramp core so it can be used when a model is built using python script or not.

I meant more like a method or function that helps the user to do the same when building and running a model in a python IDE (like the Jupyter Notebook examples in the documentation).

Originally posted by @mohammadamint in #52 (comment)

It was decided to always provide a functionality for users of the command line and users of .py files

Right now users of .py files are prompted to run a loop over the generate_single_load_profile method of the Appliance class. I think we should implement the simulation date range at the UseCase level

Example use at the appliance level

myuser = User(
    user_name = "MyUser",
    num_users = 1,
)

myapp = myuser.add_appliance(
    name = "myapp",
    ...
)

myapp.generate_single_load_profile(peak_time=..., date_start="", date_end="")

Example use at the user level

myuser.generate_aggregated_load_profile(peak_time=..., date_start="", date_end="")
uc = UseCase(name="myusecase")

uc.add_user(myuser)
uc.date_start = ""
uc.date_end = ""

uc.run()

And we would move the code which is in stochastic_process.py in methods of the UseCase class (in the command line ramp input the .xlsx files are loaded into a usecase already, so not much change would be required)

@FLomb
Copy link
Contributor

FLomb commented Feb 1, 2023

I see your point, and the change you suggest is possibly a good idea. Nonetheless, given that this is an improvement but not a bug, should we start merging the development branch into the master first, so that we can proceed with the planned outreach activities while we work on this?

@FLomb FLomb added the enhancement New feature or request label Feb 1, 2023
@Bachibouzouk
Copy link
Collaborator Author

Nonetheless, given that this is an improvement but not a bug, should we start merging the development branch into the master first, so that we can proceed with the planned outreach activities while we work on this?

Agreed :)

@Bachibouzouk Bachibouzouk linked a pull request Nov 18, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants