Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An objection for argument 'distance_rate' in environment code #44

Open
AssassinCrow opened this issue Jun 14, 2020 · 1 comment
Open

Comments

@AssassinCrow
Copy link

AssassinCrow commented Jun 14, 2020

Hello, I'm working on ROS KInetic with Ubuntu 16.04.

Anyway, according to here, the distance_rate which corresponds to reward for distance is bigger than 2 in the case of the current goal-robot distance is shorter than absolute goal-distance.

But in environment code, the distance_rate argument is smaller in the upper case; in other words, I have a feeling that it should be modified like,

from distance_rate = 2 ** (current_distance / self.goal_distance)
to distance_rate = 2 ** (self.goal_distance / current_distance)

I think the reward would get bigger and bigger when the robot gets farther from the goal point if it moves following the default code.

Would you happen to teach me why did you set the distance_rate like that?

Thanks in advance. :)

@AssassinCrow AssassinCrow changed the title An objection for distance_rate in environment code An objection for argument 'distance_rate' in environment code Jun 14, 2020
@valderrama14
Copy link

Hi, was this issue ever answered in private?
I'd actually like to know this, because the observation seems valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants