Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NaNs in test_half (test_fused_optimizer.TestFusedAdam) #63

Open
jithunnair-amd opened this issue Dec 13, 2021 · 2 comments
Open

NaNs in test_half (test_fused_optimizer.TestFusedAdam) #63

jithunnair-amd opened this issue Dec 13, 2021 · 2 comments
Assignees

Comments

@jithunnair-amd
Copy link
Collaborator

The failure for test_half (test_fused_optimizer.TestFusedAdam) is only observed on ROCm. There are some NaNs "sporadically" (99% values are correct compared to the outputs with torch.optim.Adam) showing in the outputs after apex.optimizers.FusedAdam is called to update its parameters.

@hubertlu-tw
Copy link

A PyTorch commit introduced the above failing unit tests sometime in between rocm/pytorch:rocm4.3.1_ubuntu18.04_py3.6_pytorch_1.9.0 and 2021-12-01.

@hubertlu-tw
Copy link

To further investigate this issue, please follow the below:
git clone https://github.com/ROCmSoftwarePlatform/apex.git -b dev/hubertlu/fused_adam_debug
pytest run_optimizers/test_fused_optimizer.py::TestFusedAdam -s 2>&1 | tee fused_adam_debug.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants