Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Grafana + Omniperf plugin as Docker image in a public registry like Dockerhub #418

Open
ELCapitanLLNL opened this issue Aug 24, 2024 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@ELCapitanLLNL
Copy link

ELCapitanLLNL commented Aug 24, 2024

Is your feature request related to a problem? Please describe.
no

Describe the solution you'd like
I would like do be able to pull an image of grafana with the omniperf plug-in so can I can docker pull omniperf-grafana as an example.

Describe alternatives you've considered
Currently I am using the Dockerfile provided in the repo
in https://github.com/ROCm/omniperf/blob/amd-staging/grafana/Dockerfile
However, I need to modify it to add my secret sauce, which makes it more difficult to maintain.

Additional context
Currently other omniperf images are being hosted under Mr. Ramos account at
https://hub.docker.com/u/colramos

@ELCapitanLLNL ELCapitanLLNL added the enhancement New feature or request label Aug 24, 2024
@coleramos425
Copy link
Collaborator

This should be a straightforward task. I'll need to confirm with the project PM to sign off on publishing this container. Expect an update shortly...

@ELCapitanLLNL
Copy link
Author

hi @coleramos425 , any update on this straightforward task? thank you!

@coleramos425 coleramos425 assigned njobypet and unassigned nartmada Oct 1, 2024
@coleramos425
Copy link
Collaborator

CC: @njobypet

For approval on container publishing

@njobypet
Copy link

njobypet commented Oct 1, 2024

grafana with the omniperf plug-in is a good idea. Can we use Rocprof-compute instead of Omniperf ?

@coleramos425
Copy link
Collaborator

grafana with the omniperf plug-in is a good idea. Can we use Rocprof-compute instead of Omniperf ?

Yes we can, we'll just need to wait for #428 to merge. @njobypet I am creating a subtask in Xuan's PR to make sure this is included.

@njobypet
Copy link

njobypet commented Oct 3, 2024

@coleramos425 , Please check grafana licensing requirements as well. Just to ensure that we are good to re-distribute.

@coleramos425
Copy link
Collaborator

Unfortunately, that's outside of my domain @njobypet. You'll need to reach out to the legal team. Licencing info can be found here. I'll note that in Xuan's ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants