Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: rptools-maptool URIs for Windows clients #5144

Closed
fishface60 opened this issue Jan 20, 2025 · 0 comments · Fixed by #5161
Closed

[Feature]: rptools-maptool URIs for Windows clients #5144

fishface60 opened this issue Jan 20, 2025 · 0 comments · Fixed by #5161
Labels
feature Adding functionality that adds value

Comments

@fishface60
Copy link
Contributor

Describe the Problem

I only implemented the URI handlers for Linux because that is what I have available to test and develop on. This is not useful for my Windows players.

The Solution you'd like

The jpackage config for the Windows installer includes config to install handlers for:

  • rptools-maptool+registry:///serverName
  • rptools-maptool+lan:///lanId
  • rptools-maptool+tcp://address:port

Alternatives that you've considered.

No response

Additional Context

jpackage is used to build the installer.

It generates the configuration files it needs using command-line arguments, but files can be placed into a per-platform overrides folder to replace the files used.

On Windows this is in package/windows and https://docs.oracle.com/en/java/javase/21/jpackage/override-jpackage-resources.html#GUID-405708DC-0243-49FC-84D9-B2A7F0A011A9__GUID-D0DA890C-5D6A-48A5-9380-FD18DB66F33D documents what can be overridden.

This is WIX config, creating a overrides.wxi may be sufficient.

https://stackoverflow.com/a/24889263 is an example of a snippet of wix config for creating the registry keys necessary.

It may be sufficient to add something similar to package/windows/overrides.wxi.

@fishface60 fishface60 added the feature Adding functionality that adds value label Jan 20, 2025
@fishface60 fishface60 changed the title [Feature]: rptools-maptool URIs are only implemented for Linux clients [Feature]: rptools-maptool URIs for Windows clients Jan 21, 2025
@fishface60 fishface60 mentioned this issue Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding functionality that adds value
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant