Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netcmp.c / MatchPins #88

Open
ymei opened this issue May 9, 2024 · 2 comments
Open

netcmp.c / MatchPins #88

ymei opened this issue May 9, 2024 · 2 comments

Comments

@ymei
Copy link

ymei commented May 9, 2024

I notice that the definition of MatchPins() in netcmp.c is guarded under #ifdef TCL_NETGEN, but its invocation by spice.c and verilog.c are not. This is causing linking issues on my macOS (symbol not found) if TCL_NETGEN is not defined.

@RTimothyEdwards
Copy link
Owner

Thank you for pointing this out. The #ifdef TCL_NETGEN statement got moved to the wrong position and this error went unnoticed.

However, if you are not compiling with Tcl support, then you should be, since the non-Tcl version is missing a large amount of functionality.

If you want to ensure that you are compiling the right version under Mac OS, see the instructions at:

http://opencircuitdesign.com/analog_flow/index.html

and specifically

http://opencircuitdesign.com/analog_flow/appendix_3.html

@ymei
Copy link
Author

ymei commented May 9, 2024

Thank you for pointing this out. The #ifdef TCL_NETGEN statement got moved to the wrong position and this error went unnoticed.

However, if you are not compiling with Tcl support, then you should be, since the non-Tcl version is missing a large amount of functionality.

If you want to ensure that you are compiling the right version under Mac OS, see the instructions at:

http://opencircuitdesign.com/analog_flow/index.html

and specifically

http://opencircuitdesign.com/analog_flow/appendix_3.html

Thanks. Indeed, after figuring out TCL_NETGEN, I realized that I was missing tcl/tk related arguments for configure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants