Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: .prettierignore is not functional #80

Closed
mmikhasenko opened this issue Jun 30, 2024 · 2 comments · Fixed by #81
Closed

minor: .prettierignore is not functional #80

mmikhasenko opened this issue Jun 30, 2024 · 2 comments · Fixed by #81
Assignees
Labels
🐛 Bug Something isn't working

Comments

@mmikhasenko
Copy link
Collaborator

mmikhasenko commented Jun 30, 2024

Just wasted two hours trying to understand prettier errors. It's just unintuitive.

Meanwhile, realized that our ignore file with *.ipynn won't work (checked it with test.ipynb)
https://github.com/RUB-EP1/amplitude-serialization/blob/main/.prettierignore

It seems that to ignore all notebooks, one has to write **/.ipynb
https://prettier.io/docs/en/ignore

@redeboer
Copy link
Collaborator

redeboer commented Jul 1, 2024

Sorry to hear :( Strange that they write ".prettierignore uses gitignore syntax", in which case *.ipynb should be fine... Anyway, #81 fixes this.

@redeboer
Copy link
Collaborator

Just wasted two hours trying to understand prettier errors. It's just unintuitive.

We may want to switch to Biome, one of the many upcoming Rust-based formatters that is faster than (in this case) Prettier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants