Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate origin of streams getting destroyed #5

Open
ferm10n opened this issue Mar 28, 2023 · 0 comments
Open

Investigate origin of streams getting destroyed #5

ferm10n opened this issue Mar 28, 2023 · 0 comments

Comments

@ferm10n
Copy link
Collaborator

ferm10n commented Mar 28, 2023 •
edited
Loading

I want to add a unit test that proves that a serialization error causes the stream to be destroyed.

My theory is that a handled error should not destroy the stream, but an unhandled error will. Which is why I added the try/catch here c93856c#diff-a0409bc7afd5cfb092c8a361a87db7551788ea4459b19cfb68d766c6398d4248R39-R53

The question is, how do I create an unhandled error? Might need to test stuff before the mentioned commit.

The outcome of this investigation should tell me if I should create a PR upstream.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ferm10n