Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ConfigMap to ENV support #7

Open
devholic opened this issue Dec 11, 2017 · 8 comments
Open

Add ConfigMap to ENV support #7

devholic opened this issue Dec 11, 2017 · 8 comments

Comments

@devholic
Copy link
Contributor

devholic commented Dec 11, 2017

ConfigMag, Secret에서 ENV Variable로 변경되는 기능이 추가되면 좋을 것 같습니당~

@ryuheechul
Copy link
Contributor

@devholic 무슨 이슈였는지 이제 기억이 안나네요 -0-

@cardia
Copy link

cardia commented Jul 8, 2019

galley에 하드코딩 된 무언가가 있다거나? 🤔

@winterjung
Copy link

이미 구현된 기능 아닐까요?

@ryuheechul
Copy link
Contributor

아리송송 달송..

@devholic
Copy link
Contributor Author

devholic commented Jul 8, 2019

So I updated description :doge: @ryuheechul

@ryuheechul
Copy link
Contributor

I still can't get it. Can you show me an example, please?

@devholic
Copy link
Contributor Author

devholic commented Jul 8, 2019

Current version of galley converts env variables to configmap, secret or env snippet.
I think extract env variables from configmap, secret, env snippet may help developers in some situations.

e.g.) If configmap provided as input,

apiVersion: v1
kind: ConfigMap
data:
  doge: pepe
  sunglass: true
metadata:
  name: some-configmap
  namespace: galley

extract env variables like below

doge=pepe
sunglass=true

@ryuheechul
Copy link
Contributor

Thanks! Now it's crystal clear!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants