-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Network policy should match the rasa fullname and not just rasa #75
Comments
Same thing applies to rabbit and redis:
We should be able to specify the name of the rabbit and redis pod when we use an external deployment. |
Thanks for the issue, @JustinaPetr will get back to you about it soon! You may find help in the docs and the forum, too 🤗 |
You can use the NP from Rasa-X by adding the following label to the podLabels in the values file.
Then make sure the name of redis and rabbit deployments are "redis" and "rabbitmq" respectively. |
Hello @nyejon We will come back to this ticket when we will refactor the RASA helmcharts. headsup - NP will most likely disappear from the helmcharts. perfect moment to mention We accept PR's and always did - interesting |
Hi @RASADSA The network policies are useful, they should be in at least either the Rasa X chart or the Rasa OSS chart. For many issues, all that needs to be done is standardise the way you name things in your charts. A lot of the issues are small mistakes, but the problem (as a user) has been that there are many small mistakes and it's been difficult to debug. Thanks, |
Hi, if I specify a different name, like "rasa-production" the network policies no longer apply.
See:
helm-charts/charts/rasa/templates/network-policy/rasa-bot-allow-egress-http-https.yaml
Line 9 in 2875622
It should be something like: {{ include "rasa-common.names.fullname" . }}
The text was updated successfully, but these errors were encountered: