Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant/commented out code #175

Open
DrPaulSharp opened this issue Nov 24, 2023 · 0 comments
Open

Redundant/commented out code #175

DrPaulSharp opened this issue Nov 24, 2023 · 0 comments
Labels
question Further information is requested

Comments

@DrPaulSharp
Copy link
Collaborator

DrPaulSharp commented Nov 24, 2023

The use of the following routines in the code is not clear (calls to them are either commented out or not present). I need a hand working out what they are used for. If they are not required, they should be deleted.

compile/reflectivityCalculation/reflectivityCalculationCodeOnlyScript.m
compile/reflectivityCalculation/setCompilePaths.m - Removed in #255

minimisers/DE/runDE.m - function "PlotIt" - Removed in #178

minimisers/DREAM/lowerCaseStruct.m
minimisers/DREAM/mvnorpf.m
minimisers/DREAM/Diagnostics/chisRnd.m
minimisers/DREAM/functions/DREAM.m - has this been replaced by ratDREAM.m?
minimisers/DREAM/functions/evaluateRATModel.m - Removed in #178
minimisers/DREAM/functions/GL.m
minimisers/DREAM/functions/initializeDREAMForRAT.m - Removed in #178
minimisers/DREAM/functions/measError.m
minimisers/DREAM/functions/setupDREAMForRAT.m - Removed in #178
minimisers/DREAM/functions/whittle.m
minimisers/DREAM/postprocessing/DREAMPostprocessing.m
minimisers/DREAM/postprocessing/genParSet.m
minimisers/DREAM/postprocessing/predMCMC.m

minimisers/generalUtils/checkBounds.m
minimisers/generalUtils/bayesStats/calcMCMCstatRefErrors.m
minimisers/generalUtils/bayesStats/confIntervals.m
minimisers/generalUtils/bayesStats/packPriors.m
minimisers/generalUtils/bayesStats/ratInputs.mat
minimisers/generalUtils/bayesStats/ratTest.m

minimisers/NSMain/loopCell.m
minimisers/NSMain/parseBayesResults.m
minimisers/NSMain/plotLivePointsWithEllipses.m -- Removed in #264

targetFunctions/common/groupLayers/allocateLayersForDomainsContrast.m
targetFunctions/common/reflectivityCalculations/abeles/orso_test0.m - Removed in #178
targetFunctions/common/reflectivityCalculations/abeles/orso_test1.m - Removed in #178
targetFunctions/common/reflectivityCalculations/abeles/orso_test7.m - Removed in #178
targetFunctions/common/reflectivityCalculations/abeles/test0.dat - Removed in #178
targetFunctions/common/reflectivityCalculations/abeles/test1.dat - Removed in #178
targetFunctions/common/reflectivityCalculations/abeles/test7.dat - Removed in #178

utilities/misc/kde.m

Whilst looking through these files, I am also concerned about function calls where the number/order of arguments does not appear to match the argument list in the routine.
Also, why is customModelClass a class? -- it has no properties, and only static methods. -- This is changed in #178

@DrPaulSharp DrPaulSharp added the question Further information is requested label Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant