Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test py5 imported mode #392

Closed
loiswells97 opened this issue Mar 2, 2023 · 3 comments · Fixed by #426
Closed

Test py5 imported mode #392

loiswells97 opened this issue Mar 2, 2023 · 3 comments · Fixed by #426
Assignees

Comments

@loiswells97
Copy link
Contributor

loiswells97 commented Mar 2, 2023

Check project code for py5 imported mode is working in both the editor and thonny and make any necessary fixes

@chrisruk chrisruk self-assigned this Mar 28, 2023
@create-issue-branch
Copy link
Contributor

Branch issues/392-Test_py5_imported_mode created!

@chrisruk
Copy link
Contributor

chrisruk commented Mar 28, 2023

I've been going through each of the main examples in https://github.com/RaspberryPiFoundation/editor-api/tree/65c1b13eecd9643f4a2956c259c62e4265c0d75a/lib/tasks/project_components and removing py5. and adding # Py5: imported mode at the start, to then test in the editor.

Most seem to work fine, but there where a few where the images didn't seem to display for me, although I might be doing something wrong?

target_practice_example/main.py - ok
rocket_launch_example/main.py - ok
powerful_patterns_yakan_weaving_example/main.py - ok
powerful_patterns_spirals_example/main.py - ok
powerful_patterns_random_faces_example/main.py - ok
powerful_patterns_mcewen_tartan_example/main.py - ok
powerful_patterns_kek_lepis_sarawak/main.py - ok
powerful_patterns_art_deco_wallpaper_example/main.py - ok
make_a_face_tribal_mask_example/main.py - ok
make_a_face_stacked_faces_example/main.py - ok
make_a_face_kawaii_fruit_example/main.py - ok
make_a_face_interactive_example/main.py - ok
make_a_face_animated_example/main.py - ok
dont_collide_skiing_cat_example/main.py - can't see the skiing cat, but can see trees
dont_collide_dont_pop_example/main.py - can't see balloon, can see cacti
dont_collide_dodge_asteroids_example/main.py - can't see rocket, can see moons
dont_collide_clean_car_example/main.py - ok
dont_collide_avoid_germs_example/main.py - couldn't see players character

@maddyjoe
Copy link
Contributor

maddyjoe commented Mar 29, 2023

Just so we don't lose it AND can remember to close it when no longer needed for testing - the original PR/Issue for "Draft updates to use py5 in first python path" is this badger as an issue RaspberryPiFoundation/editor-api#118 and this one as a PR RaspberryPiFoundation/editor-api#122

My understanding is that we don't intend to merge it given we're doing the magic comment stuff instead.

loiswells97 added a commit that referenced this issue Apr 4, 2023
# What's Changed?

- Slight cypress test refactor

closes #392

---------

Co-authored-by: chrisruk <[email protected]>
Co-authored-by: Lois Wells <[email protected]>
Co-authored-by: Lois Wells <[email protected]>
Co-authored-by: Scott Adams <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants