Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error checking #19

Closed
apocatarsis opened this issue Feb 7, 2016 · 3 comments
Closed

Error checking #19

apocatarsis opened this issue Feb 7, 2016 · 3 comments

Comments

@apocatarsis
Copy link
Collaborator

We should add some error checking once in a while during the execution, to check if the device is still present (stopping/pausing the execution until it is back online) or has changed between the docking/plugged mode.

And we should also do error checking in every step of the initialization.

@Destroyer
Copy link
Collaborator

I think we can try to look for connected devices instead and if there're any and we are successful in opening them, we can continue execution. Ofc if the devices are plugged out we exit completly and after they're plugged back in systemd should start the daemon again (related to #20 ) .

Regarding inicialization I don't quite understand what do you mean. I think we're doing good job of providing error messages to the user during init. There're just few minor things that could be done differently - stoi exceptions aren't handled so if stoi fails the daemon goes down and parsing itself is not perfect. But rewriting it for this purpose is a waste of time for me right now.

@Destroyer
Copy link
Collaborator

Destroyer commented Oct 6, 2016

Should be also fixed with #20 in Destroyer@55ce5a2

@RaulPPelaez
Copy link
Owner

Agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants