Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buttons 13 and 14 can't detect release #66

Open
lostallmymoney opened this issue Mar 12, 2019 · 2 comments
Open

buttons 13 and 14 can't detect release #66

lostallmymoney opened this issue Mar 12, 2019 · 2 comments
Labels

Comments

@lostallmymoney
Copy link

lostallmymoney commented Mar 12, 2019

if (ev2[1].type == 1 && ev2[1].value == 1) //Only extra buttons
switch (ev2[1].code) {
case 275:
case 276:
chooseAction(ev2[1].code - OFFSET, 1);
break;
// do nothing on default
}

should be

if (ev2[1].type == 1) //Only extra buttons
switch (ev2[1].code) {
case 275:
case 276:
chooseAction(ev2[1].code - OFFSET, ev2[1].value);
break;
// do nothing on default
}

The current version makes people unable to run things when releasing the 13th and 14th buttons.
I also suggest "upgrading" to my version for an easier to edit code using classes ;)

@lostallmymoney
Copy link
Author

Someone should fix this

@RaulPPelaez
Copy link
Owner

I see, you can make a pull request with this change and I will merge it. If you dont feel like it I will do it.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants