Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to autotools 2.72 #289

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

skangas
Copy link

@skangas skangas commented Jul 24, 2024

This provides a more complete fix for #281 than PR #283 does. I've also included the manual steps below, which should be easily reproducible. This is an alternative to merging this patch outright (depending on your level of cautiousness after the xz backdoor).

Please see below the commit message.

Thanks!


This essentially just does the following, with autotools 2.72 installed:

$ cp /usr/lib/share/autoconf/build-aux/config.guess \
    tool/autoconf/build-aux/config.guess
$ cp /usr/lib/share/autoconf/build-aux/config.sub \
    tool/autoconf/build-aux/config.sub
$ autoreconf
configure.ac:28: warning: The macro 'AC_LANG_C' is obsolete.
configure.ac:28: You should run autoupdate.
./lib/autoconf/c.m4:72: AC_LANG_C is expanded from...
configure.ac:28: the top level
$ autoupdate

After running autoupdate, the following manual fix was needed:

-        [m4_esyscmd_s(sed -n '/^#define MPS_RELEASE "\(.*\)"$/{s/.*"\(.*\)"/\1/;p;}' code/version.c)],
+        [m4_esyscmd_s([sed -n '/^#define MPS_RELEASE "\(.*\)"$/{s/.*"\(.*\)"/\1/;p;}' code/version.c])],

This essentially just does the following, with autotools 2.72 installed:

    $ cp /usr/lib/share/autoconf/build-aux/config.guess \
        tool/autoconf/build-aux/config.guess
    $ cp /usr/lib/share/autoconf/build-aux/config.sub \
        tool/autoconf/build-aux/config.sub
    $ autoreconf
    configure.ac:28: warning: The macro 'AC_LANG_C' is obsolete.
    configure.ac:28: You should run autoupdate.
    ./lib/autoconf/c.m4:72: AC_LANG_C is expanded from...
    configure.ac:28: the top level
    $ autoupdate

After running autoupdate, the following manual fix was needed:

-        [m4_esyscmd_s(sed -n '/^#define MPS_RELEASE "\(.*\)"$/{s/.*"\(.*\)"/\1/;p;}' code/version.c)],
+        [m4_esyscmd_s([sed -n '/^#define MPS_RELEASE "\(.*\)"$/{s/.*"\(.*\)"/\1/;p;}' code/version.c])],
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant