Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements #3

Open
roelderickx opened this issue Jan 9, 2022 · 0 comments
Open

Improvements #3

roelderickx opened this issue Jan 9, 2022 · 0 comments

Comments

@roelderickx
Copy link

Hello,

I needed a few improvements in this library so I decided to implement them in a fork. Would you appreciate a pull request for this?

  • A function log_browser_console is added to add log messages in the browser console. Always helpful while developing.
  • encode_message is integrated in send_message. I know where you got the code from but it requires the user of the library to know what kind of input send_message exactly requires. This is not clearly documented, except that encode_message must be called. It simply looks superfluous in the code using the library.
  • An install() function is added. I would like the user of my software to be able to simply click 'Enable for Firefox' or 'Enable for Chrome' in stead of executing nativemessaging-install.py manually. Of course a manual installation is still possible with my version, it just calls the same install procedure.
  • I did not yet increment the version number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant