Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert remaining std::throw to Rcpp::stop #401

Closed
eddelbuettel opened this issue Dec 3, 2024 · 0 comments
Closed

Convert remaining std::throw to Rcpp::stop #401

eddelbuettel opened this issue Dec 3, 2024 · 0 comments
Assignees
@eddelbuettel

Comments

@eddelbuettel
Copy link
Member

As seen in #400 we have still Rcpp::cerr << message; throw std::logic_errror(...) in the code. A while back Rcpp improved its exception handling and stack unwinding which, in the context of R and its managed memory, is preferable.

We should probably convert these, and I am opening this issue to remind (and assign) myself.
@eddelbuettel eddelbuettel self-assigned this Dec 3, 2024
eddelbuettel added a commit that referenced this issue Dec 7, 2024
@eddelbuettel
Merge pull request #402 from Rblp/feature/use_rcpp_stop
a914bbb 
Use Rcpp::stop instead of throw (closes #401)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eddelbuettel eddelbuettel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eddelbuettel