-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use release 3.24.6.1 #397
Use release 3.24.6.1 #397
Conversation
Dump logs in CI if failure Update install_name_tool call
Looks good from my end. I don't see the option to approve, if you'd like to request a review for good order I'll approve it, otherwise this comment can suffice. |
Thanks! I now tagged you explicitly, maybe that makes a difference? Otherwise I find if one goes into 'Files changed' (the right-most menu in the bar under the title) it usually offers the selection. I.e. screenshot of the menu: It should lead to which (here, for me) only offers 'comment' as I cannot approve a PR I started. You should have the 'Approve' button and of course the edit field if you want to use it. And of course one can comment per-file and per-line as usual. |
I am going to make this a 'squash and merge'. We will see if this stick but linear and compact git histories are nice in some other repositories. Once merged we can let this 'sit' for a bit, announce the new binaries available via r-universe and then release to CRAN in a few days now backed by two real tests already. |
This PR switches to release 3.24.6.1 of the Bloomberg API, and enables arm64 builds for macOS.
We attempted to resurrect x86_64 builds for macOS. As the current release of the Bloomberg API supports only arm64 on macOS, we retain the previouse. And while that built fine previously it somehow now fails (at r-universe) for that platform. It may hence also fail at CRAN for macOS x86_64. We would need to rely on someone with that platform to debug more locally.
After approving please do not merge immediately but allow me to do so also in preparation of a next release.