-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undeterminable Kinetics Error of Surface_Abstraction_vdW family #2122
Comments
Previous discussion in RMG-website issue ReactionMechanismGenerator/RMG-website#219 |
more generally I think it is also related to #2106. |
I think PR #2131 should fix this |
I think that PR should fix the |
Similar error in Surface_Abstraction_Single_vdW family
A quick solution is applying forbbiden block to avoid bidentates
Another error in Surface_Dual_Adsorption_vdW family
A quick solution is applying forbbiden block to avoid bidentates
and
|
So I think what is actually causing the This open PR also globally forbids vdW rads |
The errors can be reproduced by running the following input file on the vdw_radical branch(RMG-database) and master(RMG-Py):
|
Thanks @Tingchenlee ! I was able to reproduce that error with that input file and those branches.
I can open a PR, hopefully tomorrow, to fix 1 and 2 and perhaps 3 but I think more discussion is needed for 3. |
Catalysis fixes - vdw radicals, bidentates, resonance vdw radicals - We previously implemented a multiplicity check to ensure products in the reverse direction match the multiplicity of the template reactants . However, we are getting vdw products that do not obey multiplicity restriction in the forward direction (#2122) , so we also need to check this direction as well. radicals on X - if resonance generation puts radicals/lone pairs/or a formal charge on X, RMG crashes. I added a commit on this PR to filter out these structures bidentate vdw - We were getting bidentate vdw structures. This PR makes them forbidden for surface families
This issue is being automatically marked as stale because it has not received any interaction in the last 90 days. Please leave a comment if this is still a relevant issue, otherwise it will automatically be closed in 30 days. |
Bug Description
The reactions crashed when the bidentate species tried to match the reverse template of Surface_Abstraction_vdW family. There were three problem reactions so far:
How To Reproduce
Maybe an easier way to reproduce these is using the kinetic search of the RMG website, here are the error messages
Expected Behavior
The text was updated successfully, but these errors were encountered: