Remove RMG-Java code and fix various related glitches #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacksonBurns
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We decided several months ago that RMG-Py will no longer support any RMG-Java functionality (see ReactionMechanismGenerator/RMG-Py@9f293be).
This means that RMG-website also will not be able to support those functions, unless some of the functions are ported over. Indeed, the
save_html_filethat was removed from RMG-Py was used in some of the RMG-website tools.This PR
To reduce the possibility of further error, and to be consistent with RMG-Py's philosophy, this PR removes any code related to RMG-Java. It also fixes a couple of related errors:
save_html_filerather than trying to import this removed function from RMG-Pyblank=True, null=Trueto many of the model forms which appear to be required(or at least a workaround) for getting the tools to work (see here; this is slightly undesirable behavior, as now the page can be submitted without uploading any files, but this shouldn't cause any significant issues)Side note
This is not the first time that removal of deprecated RMG-Py code affected RMG-website downstream. We may want to consider including the RMG website build into the RMG-Py CI workflow, but I think this would be too slow/perhaps unnecessary.
Another option is to set up CI for RMG-website; that way we can catch these errors at least during PRs and during regular build tests. (See #280)