feat(breaking): update to Manopt 0.5 #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvdmitri
requested changes
Nov 6, 2024
| @@ -518,7 +518,7 @@ end | |||
| nothing, | |||
| ) | |||
| initialpoint = rand(manifold) | |||
| direction = MomentumGradient(manifold, initialpoint) | |||
| direction = Manopt.MomentumGradientRule(manifold; p=initialpoint) | |||
There was a problem hiding this comment.
I think the new Manopt doesn't require manifold as an argument? I think we can use the better improved API
Nimrais
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
==========================================
- Coverage 99.24% 99.23% -0.01%
==========================================
Files 7 7
Lines 264 263 -1
==========================================
- Hits 262 261 -1
Misses 2 2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
bvdmitri
approved these changes
Nov 21, 2024
| @@ -557,5 +557,6 @@ end | |||
|
|
|||
| @test approximated isa MvNormalMeanCovariance | |||
| @test kldivergence(approximated, true_dist) < 0.01 # Ensure good approximation | |||
| @test projection.parameters.direction isa MomentumGradient | |||
| @show typeof(projection.parameters.direction) | |||
There was a problem hiding this comment.
Suggested change
| @show typeof(projection.parameters.direction) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.