Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support BigFloat arguments #5

Merged
merged 3 commits into from
Oct 7, 2023
Merged

Support BigFloat arguments #5

merged 3 commits into from
Oct 7, 2023

Conversation

bvdmitri
Copy link
Member

@bvdmitri bvdmitri commented Oct 6, 2023

This support fixes the dispatch, such that BigFloat matrices are supported now

@bvdmitri bvdmitri requested a review from bartvanerp October 6, 2023 12:01
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (56a15dc) 88.57% compared to head (087eb8e) 91.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #5      +/-   ##
==========================================
+ Coverage   88.57%   91.42%   +2.85%     
==========================================
  Files           2        2              
  Lines          70       70              
==========================================
+ Hits           62       64       +2     
+ Misses          8        6       -2     
Files Coverage Δ
src/FastCholesky.jl 96.61% <100.00%> (+3.38%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bartvanerp
Copy link
Member

I can indeed see the difference in dispatch between the different methods, but were they not supported at the start?

julia> Matrix{<:BigFloat} <: Matrix{<:AbstractFloat}
true

@bvdmitri
Copy link
Member Author

bvdmitri commented Oct 6, 2023

Indeed, that's the issue at hand. The problem lies in the fact that this method errors when dealing with BigFloats because the inv! operation is not supported for BigFloats.

To address this issue, this pull request (PR) eliminates the dispatch for BigFloats since BlasFloat does not include BigFloats. Consequently, BigFloats will no longer utilize this specific method but will instead use a more generic version.

@bartvanerp
Copy link
Member

Makes total sense now.

@bvdmitri bvdmitri merged commit fe32000 into main Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants