-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CVIProjection with constraints on interfaces #428
Conversation
It seems to me that |
There are pros and cons to this suggestion. The problem arises from our design decisions in By keeping
Or do you mean to have a union for |
I don't agree with this, lets discuss in person. Having ability to pass
Not really, you can always do |
Co-authored-by: Bagaev Dmitry <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #428 +/- ##
==========================================
- Coverage 72.62% 71.93% -0.70%
==========================================
Files 190 190
Lines 5454 5466 +12
==========================================
- Hits 3961 3932 -29
- Misses 1493 1534 +41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@bvdmitri codecoverage is working now! I see coverage for the project fails however it's good for the patch. And the project codecoverage report is not informative for me. |
Yeah afaik project coverage in Julia is stochastic, so it can fluctuate a bit, no worries. I approved the PR, you can merge, good job! |
Added flexibility to projection forms in CVI rules
Changes
Enhanced CVIProjection with projection forms control
out_prjparams
parameter to control output edge projection formin_prjparams
parameter as a NamedTuple to control input edge projection formsAdded flexible form selection mechanism
get_kth_in_form
to safely access input forms by indexOptimized projection logic
Example Usage
Benefits
Let me know if any parts need clarification or expansion!