Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] "Tree Variants" tweaks #25

Open
vico93 opened this issue May 2, 2023 · 6 comments
Open

[Feature Request] "Tree Variants" tweaks #25

vico93 opened this issue May 2, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@vico93
Copy link

vico93 commented May 2, 2023

  • Change the Blossoming tree (log, leaves and sapling) to match 1.20's Cherry tree textures and sound;
  • If BoP is ON, automatically disable Blossoming trees from worldgen (while keeping Swamp Oak Trees intact).
@Foreck1
Copy link
Member

Foreck1 commented May 2, 2023

I would like to add that while both look like cherry trees, both have different names, slightly different textures, and Quark's spawn exclusively on extreme hills (also both have separate dynamic trees addons). So the second suggestion should be an option, probably off by default.

@vico93
Copy link
Author

vico93 commented May 2, 2023

Eh, you have a point. But considering that there is no Cherry Grove biome on vanilla 1.12, spawning on Extreme Hills is the least of the issues.

@Foreck1
Copy link
Member

Foreck1 commented May 2, 2023

My point was that, were you to install BoP, Quark's cherry trees wouldn't overlap with them as they would generate in totally different biomes for totally different purposes. If you just install BoP, for example, you won't get the "sakura hills" that Quark intended to add, and if you just install Quark, you won't get the "cherry blossom grove" that BoP intended to add.

@vico93
Copy link
Author

vico93 commented May 2, 2023

Understand. So the "reskin" request should do more sense for BoP's cherry trees.

@Foreck1
Copy link
Member

Foreck1 commented May 2, 2023

Not necessarily, the reskin is fine (first suggestion); but deactivating Quark's cherry trees when BoP is installed should be off by default (second suggestion).

@vico93
Copy link
Author

vico93 commented May 2, 2023

ahh i understand, sorry for my confusion

@Foreck1 Foreck1 added the enhancement New feature or request label May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants