Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Variable renaming is broken #28

Open
ostrich opened this issue Apr 14, 2023 · 3 comments
Open

Bug: Variable renaming is broken #28

ostrich opened this issue Apr 14, 2023 · 3 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ostrich
Copy link

ostrich commented Apr 14, 2023

The gif shows the issue.

Steps to reproduce:

  1. Create variables with set "foo=foo.txt" and set "bar=bar.txt" and use them elsewhere in the script.
  2. Click the variables and hit F2 to rename
  3. Enter a new name for each
  4. Neither works. The foo in set "foo=foo.txt" is not renamed but %foo% is. And neither bar nor %bar% is renamed.

Code_3fvOSrzs0O

@ostrich
Copy link
Author

ostrich commented Apr 22, 2023

Hate to be a pest but hoping @gustavosimon sees this :)

@gustavosimon
Copy link
Collaborator

Hello @ostrich ! How are u? Hope you're well.

First, thanks for opening this issue. I really appreciate that the extension is used by the community.

About the issue, I'm currently working in another projects but I'll see this as soon as possible.

You may be comfortable to submit a pull request to fix this issue.

This is applied to the another feature request created too.

Thanks and have a good day!

@gustavosimon gustavosimon self-assigned this Apr 22, 2023
@gustavosimon gustavosimon added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Apr 22, 2023
@skorpio07
Copy link

one last comment is the following will work (but not optimal)
set var=foo
echo var
now rename var. it works in both places. but the quotes are necessary, so this is a def bug.
thanks for the great work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants