Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deny renaming reserved cmd commands #29

Open
gustavosimon opened this issue May 6, 2023 · 1 comment
Open

Deny renaming reserved cmd commands #29

gustavosimon opened this issue May 6, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@gustavosimon
Copy link
Collaborator

This issue is a @EmilySeville7cfg suggestion.

Given the following code:

set variable=value
rem some other code
set another_variable=another_value

renaming set -> bla results in:

bla variable=value
rem some other code
bla another_variable=another_value

I think it's better to deny renaming for internal cmd commands. Just checked this issue out.

As a sidenote, I guess just variables and labels should be allowed to be renamed. What about this?

@gustavosimon
Copy link
Collaborator Author

@EmilySeville7cfg

I was searching about this and reserved commands do not be able to be renamed.

Like in Java source code, the VsCode doesn't allow rename reserved commands.

See this image:

image

So, I'm opening this issue as an enhancement to the extension.

Thank u for the suggestion!

@gustavosimon gustavosimon self-assigned this May 6, 2023
@gustavosimon gustavosimon added enhancement New feature or request help wanted Extra attention is needed labels May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant