-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking HttpEndpoint creation #83
Comments
Hi |
Hi, I think a cleaner way would be to add a boolean parameter to the What do you think of this solution? Also, I'm curios, what use-case do you have that requires you to wait until the endpoint is listening? Thanks |
I think returning a Task is a better option, because it lets you do other things while listener is starting, and still be able to track over the Task to know whether it succeeded in listening or not. The use-case is an application which needs to fail if the http listening did not succeed, for example, if it doesn't have the permissions to listen on the specific port. |
Hi
I would like to add the ability of tracking the creation of Http listener (after calling MetricsConfig.WithHttpEndpoint).
This will enable me to wait until endpoint is listening before proceeding with my process.
I would like to create a pull request, but I don't know what is the preferred way to do this.
I can think about 3 different options:
Please advise which option I should go with, or if you have some better idea.
Thanks !
The text was updated successfully, but these errors were encountered: