Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment is set in too many places #243

Open
pwaller opened this issue Dec 10, 2018 · 0 comments
Open

Environment is set in too many places #243

pwaller opened this issue Dec 10, 2018 · 0 comments

Comments

@pwaller
Copy link
Contributor

pwaller commented Dec 10, 2018

At the moment the environment is set in too many places:

  • During build of host AMI.
  • In compiler docker image.
  • In job definition.
  • In job runtime overrides (platform).
  • reco-aws.sh
  • sdaccel-builder.mk
  • settings.sh in the root of reco-sdaccel

This makes it very hard to quickly make a reproducible developer environment, and diagnose runtime issues. It adds a lot of cognitive overhead during development and firefighting.

I suggest we find one place to configure the environment, try to minimize it, and remove all other tweaks to the environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant