Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest Valkyrie and RenderLib incompatibility #23

Open
1 of 2 tasks
shizotoaster opened this issue Aug 21, 2023 · 8 comments
Open
1 of 2 tasks

Latest Valkyrie and RenderLib incompatibility #23

shizotoaster opened this issue Aug 21, 2023 · 8 comments

Comments

@shizotoaster
Copy link

Describe the bug

A clear and concise description of what the bug is.

Valkyrie is incompatible with RenderLib. That didn't happen before so it is probably something with latest updates of valkyrie or RenderLib

Reproducibility

  • I reproduced this issue with as few other mods as possible installed.
  • I am unable to reproduce this issue consistently.

To Reproduce

Steps to reproduce the behavior:

  1. Install Valkyrie alongside RenderLib
  2. Launch the game
  3. BOOM! Mixin conflict crash

Expected behavior

Game launches and works correctly

Logs or/and crash reports

https://mclo.gs/CdteFbu

Versions

  • Valkyrie: 0.2-Dev-8

  • Red Core: 0.4-Dev-5

  • ConfigAnytime: 1.0

  • MixinBooter: 8.4

  • RenderLib: 1.3.3

  • Forge: 1.12.2 - 14.23.5.2860

  • Java: 1.8.0-382

  • Java JVM: Bellsoft Liberica

Specification:

  • OS: Windows 11
  • CPU: Ryzen 5 5600g
  • GPU: Radeon RX 570 4gb OC
  • RAM Allocated: 4096mb
@Desoroxxx
Copy link
Member

Yeah latest RenderLib causes incompatibilities I will fix it this week, but reverting to a slightly older renderlib is completly fine in the meanwhile the changes where mainly on the debug side of things iirc

@Xisdar
Copy link

Xisdar commented Aug 26, 2023

I may have had a similar problem.
Also Valkyrie and RenderLib in the assembly
When disabling Valkyrie the problem disappeared.
Pack of mods for optimization are used from here
Here was a problem with minixes
Although it is not explicitly stated that Valkyrie and RenderLib are to blame.

@Desoroxxx
Copy link
Member

Just use the workaround said here:

reverting to a slightly older renderlib is completly fine in the meanwhile the changes where mainly on the debug side of things iirc

@ChromaPIE
Copy link

any follow up on this issue?

@Desoroxxx
Copy link
Member

any follow up on this issue?

I need to work on it probably next dev build, currently going around my mod doing huge quality of life improvement internally

@KnightCa
Copy link

Using RenderLib version 1.3.2 works for now (one version older from most recent).

Sounds like a full compatibility is in development for version 1.3.3.

@Natedogwoooof
Copy link

still crashes btw

@Desoroxxx
Copy link
Member

still crashes btw

I know under a lot of work right now, trying to get things done, sorry for the wait

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants