Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add search index to Frontend spec #194

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Add search index to Frontend spec #194

merged 1 commit into from
Oct 14, 2024

Conversation

Hyperkid123
Copy link
Contributor

https://issues.redhat.com/browse/RHCLOUD-35421

Adds a new attribute to the Frontend resource spec

@Hyperkid123 Hyperkid123 requested a review from a team October 14, 2024 13:55
florkbr
florkbr approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@florkbr florkbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This shouldn't effect the output of the FEO today - though if we have issues we may need to engage devprod.

@Hyperkid123 Hyperkid123 merged commit acb17bd into RedHatInsights:main Oct 14, 2024
11 checks passed
@Hyperkid123 Hyperkid123 deleted the search-index-spec branch October 14, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florkbr florkbr florkbr approved these changes

@psav psav psav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hyperkid123 @psav @florkbr