You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The insights-client itself uploads some data to somewhere, using the MetricsHTTOPClient in run.py. I found that to be quite fragile for something that is non-essential to the working of Insights.
Constructing a MetricsHTTPClient will fail (with a mysteriously error message) when there is no /etc/rhsm/rhsm,.conf file, or if that file does not contain the expected keys. I think uploads should just be skipped if the MetricsHTTPClient can't figure out where to upload to.
Actual upload errors are only ignored when they are OSErrors. We get SSLErrors in our test suite because the client does not honor the insecure setting in rhsm.conf. I think any error should be allowed.
The text was updated successfully, but these errors were encountered:
The insights-client itself uploads some data to somewhere, using the
MetricsHTTOPClient
inrun.py
. I found that to be quite fragile for something that is non-essential to the working of Insights.Constructing a
MetricsHTTPClient
will fail (with a mysteriously error message) when there is no /etc/rhsm/rhsm,.conf file, or if that file does not contain the expected keys. I think uploads should just be skipped if the MetricsHTTPClient can't figure out where to upload to.Actual upload errors are only ignored when they are OSErrors. We get SSLErrors in our test suite because the client does not honor the
insecure
setting in rhsm.conf. I think any error should be allowed.The text was updated successfully, but these errors were encountered: