Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics uploading is quite fragile #135

Open
mvollmer opened this issue Dec 10, 2020 · 0 comments
Open

Metrics uploading is quite fragile #135

mvollmer opened this issue Dec 10, 2020 · 0 comments

Comments

@mvollmer
Copy link

mvollmer commented Dec 10, 2020

The insights-client itself uploads some data to somewhere, using the MetricsHTTOPClient in run.py. I found that to be quite fragile for something that is non-essential to the working of Insights.

  • Constructing a MetricsHTTPClient will fail (with a mysteriously error message) when there is no /etc/rhsm/rhsm,.conf file, or if that file does not contain the expected keys. I think uploads should just be skipped if the MetricsHTTPClient can't figure out where to upload to.

  • Actual upload errors are only ignored when they are OSErrors. We get SSLErrors in our test suite because the client does not honor the insecure setting in rhsm.conf. I think any error should be allowed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant