Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run_phase: explicit handling of process.returncode values #50

Open
d-hat opened this issue Feb 6, 2018 · 1 comment
Open

run_phase: explicit handling of process.returncode values #50

d-hat opened this issue Feb 6, 2018 · 1 comment

Comments

@d-hat
Copy link

d-hat commented Feb 6, 2018

run_phase() has stanzas for process.returncode in [0, 1, >=100] but other values fall through without any action or logging. For robustness it's probably wise to catch other values and log a message. Particularly process.returncode<0 which indicates the subprocess was killed by a signal.

@kylape
Copy link
Member

kylape commented Feb 8, 2018

Sounds like a good thing to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants