Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

specs for parser ls_osroot #28

Open
TripleJQK opened this issue Apr 16, 2018 · 6 comments
Open

specs for parser ls_osroot #28

TripleJQK opened this issue Apr 16, 2018 · 6 comments

Comments

@TripleJQK
Copy link
Contributor

TripleJQK commented Apr 16, 2018

RedHatInsights/insights-core#1094

ls_tmp = simple_command("/bin/ls -ld /tmp")

ls_tmp = simple_file("insights_commands/ls_-ld_.tmp")

@bfahr
Copy link
Contributor

bfahr commented Apr 18, 2018

This has changed since originally submitted, the spec are now for osroot instead of tmp:

ls_osroot = RegistryPoint()
ls_osroot = simple_command("/bin/ls -lan /")
ls_osroot = simple_file("insights_commands/ls_-lan")

@xiangce
Copy link
Contributor

xiangce commented Apr 19, 2018

Just fixed a typo (Added a dot to the end) in the simple_file:
ls_osroot = simple_file("insights_commands/ls_-lan.")

@TripleJQK
Copy link
Contributor Author

TripleJQK commented Apr 19, 2018

it seems that it should be ls_osroot = simple_file("insights_commands/ls_-lan_."),
sorry for my mistake

@TripleJQK
Copy link
Contributor Author

ls_osroot = RegistryPoint()
ls_osroot = simple_command("/bin/ls -lan /")
ls_osroot = simple_file("insights_commands/ls_-lan_.")

@xiangce
Copy link
Contributor

xiangce commented May 8, 2018

I think we made a mistake in the simple_file, there is no way to set the simple_file string (insights_commands/ls_-lan_.) for simple_command in the uploader.json file. And the default simple_file (generated by the mangle command) for /bin/ls -lan / is insights_commands/ls_-lan but not insights_commands/ls_-lan_. (ends with a .).

However, the current FileListing parser cannot handle the generated insights_commands/ls_-lan (without the ending .) correctly.

@csams, @kylape - would you please take a look at above issue?

For details please see RedHatInsights/insights-core#1094

@kylape kylape changed the title specs for parser ls_ld_tmp specs for parser ls_osroot May 8, 2018
@xiangce
Copy link
Contributor

xiangce commented Jun 26, 2018

jhjaggars pushed a commit to jhjaggars/insights-frontend-assets that referenced this issue Nov 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants