From 2cd8fd67c42201018b9edd4780e911bcfc5c0f77 Mon Sep 17 00:00:00 2001 From: Pavel Tisnovsky Date: Thu, 19 Aug 2021 09:29:49 +0200 Subject: [PATCH 1/7] Messages without attribute --- README.md | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/README.md b/README.md index 4848cccb6..ca5f9fd82 100644 --- a/README.md +++ b/README.md @@ -105,6 +105,17 @@ Please look into [this document](messages/broken/README.md) for detailed descrip +#### Messages with invalid format - missing account number + +These messages should be rejected by *Insights Results Writer* and also by *CCS +Notification Writer* services as the `account_number` attribute is missing. + +These messages are stored in `messages/invalid_no_account_number/` subdirectory. + +Please look into [this document](messages/invalid_no_account_number/README.md) for detailed description. + + + ## Test data `github.com/RedHatInsights/insights-results-aggregator-data/testdata` package contains files with repeated data From bc3f9b75f7ca405372f38c4ea299e92b63b6db43 Mon Sep 17 00:00:00 2001 From: Pavel Tisnovsky Date: Thu, 19 Aug 2021 09:30:22 +0200 Subject: [PATCH 2/7] Messages without attribute --- README.md | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/README.md b/README.md index ca5f9fd82..75fe79690 100644 --- a/README.md +++ b/README.md @@ -116,6 +116,17 @@ Please look into [this document](messages/invalid_no_account_number/README.md) f +#### Messages with invalid format - missing cluster name + +These messages should be rejected by *Insights Results Writer* and also by *CCS +Notification Writer* services as the `cluster_name` attribute is missing. + +These messages are stored in `messages/invalid_no_cluster_name/` subdirectory. + +Please look into [this document](messages/invalid_no_cluster_name/README.md) for detailed description. + + + ## Test data `github.com/RedHatInsights/insights-results-aggregator-data/testdata` package contains files with repeated data From bf460ce3454f4439b394bd307bde469495e6bba7 Mon Sep 17 00:00:00 2001 From: Pavel Tisnovsky Date: Thu, 19 Aug 2021 09:30:59 +0200 Subject: [PATCH 3/7] Messages without attribute --- README.md | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/README.md b/README.md index 75fe79690..844662bfe 100644 --- a/README.md +++ b/README.md @@ -127,6 +127,17 @@ Please look into [this document](messages/invalid_no_cluster_name/README.md) for +#### Messages with invalid format - missing last checked timestamp + +These messages should be rejected by *Insights Results Writer* and also by *CCS +Notification Writer* services as the `last_checked` attribute is missing. + +These messages are stored in `messages/invalid_no_last_checked/` subdirectory. + +Please look into [this document](messages/invalid_no_last_checked/README.md) for detailed description. + + + ## Test data `github.com/RedHatInsights/insights-results-aggregator-data/testdata` package contains files with repeated data From e69ab88754ebbbca86c7b992ff276981481c6a07 Mon Sep 17 00:00:00 2001 From: Pavel Tisnovsky Date: Thu, 19 Aug 2021 09:32:18 +0200 Subject: [PATCH 4/7] Messages without attribute --- README.md | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/README.md b/README.md index 844662bfe..33030c99b 100644 --- a/README.md +++ b/README.md @@ -138,6 +138,17 @@ Please look into [this document](messages/invalid_no_last_checked/README.md) for +#### Messages with invalid format - missing organization ID + +These messages should be rejected by *Insights Results Writer* and also by *CCS +Notification Writer* services as the `org_id` attribute is missing. + +These messages are stored in `messages/invalid_no_organization_id/` subdirectory. + +Please look into [this document](messages/invalid_no_organization_id/README.md) for detailed description. + + + ## Test data `github.com/RedHatInsights/insights-results-aggregator-data/testdata` package contains files with repeated data From bdb8580991628dc7a97c7f8b3365e85746763961 Mon Sep 17 00:00:00 2001 From: Pavel Tisnovsky Date: Thu, 19 Aug 2021 09:32:47 +0200 Subject: [PATCH 5/7] Messages without attribute --- README.md | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/README.md b/README.md index 33030c99b..f663ba8ea 100644 --- a/README.md +++ b/README.md @@ -149,6 +149,17 @@ Please look into [this document](messages/invalid_no_organization_id/README.md) +#### Messages with invalid format - missing version info + +These messages should be rejected by *Insights Results Writer* and also by *CCS +Notification Writer* services as the `version` attribute is missing. + +These messages are stored in `messages/invalid_no_version/` subdirectory. + +Please look into [this document](messages/invalid_no_version/README.md) for detailed description. + + + ## Test data `github.com/RedHatInsights/insights-results-aggregator-data/testdata` package contains files with repeated data From 6d3a8b13981073f58bce8767c2b2cd0a607679ac Mon Sep 17 00:00:00 2001 From: Pavel Tisnovsky Date: Thu, 19 Aug 2021 09:33:31 +0200 Subject: [PATCH 6/7] Messages without attribute --- README.md | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/README.md b/README.md index f663ba8ea..bd1a40209 100644 --- a/README.md +++ b/README.md @@ -160,6 +160,17 @@ Please look into [this document](messages/invalid_no_version/README.md) for deta +#### Messages with invalid format - missing report + +These messages should be rejected by *Insights Results Writer* and also by *CCS +Notification Writer* services as the whole report is missing (just other attributes are there). + +These messages are stored in `messages/invalid_no_report/` subdirectory. + +Please look into [this document](messages/invalid_no_report/README.md) for detailed description. + + + ## Test data `github.com/RedHatInsights/insights-results-aggregator-data/testdata` package contains files with repeated data From ebd293d5f413ec4c76592dab07e50ffe4cba6a25 Mon Sep 17 00:00:00 2001 From: Pavel Tisnovsky Date: Thu, 19 Aug 2021 09:41:13 +0200 Subject: [PATCH 7/7] Fixed typos --- README.md | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/README.md b/README.md index bd1a40209..0a43c23b8 100644 --- a/README.md +++ b/README.md @@ -95,7 +95,7 @@ Please look into [this document](messages/normal_for_notification_tests/README.m #### Messages with unexpected format and/or content -These messages should be rejected by *Insights Results Writer* and also by *CCS +These messages should be rejected by *Insights Results Writer* and also by *CCX Notification Writer* services as their format is unexpected or wrong at all. OTOH such data are very valuable for testing etc. @@ -107,7 +107,7 @@ Please look into [this document](messages/broken/README.md) for detailed descrip #### Messages with invalid format - missing account number -These messages should be rejected by *Insights Results Writer* and also by *CCS +These messages should be rejected by *Insights Results Writer* and also by *CCX Notification Writer* services as the `account_number` attribute is missing. These messages are stored in `messages/invalid_no_account_number/` subdirectory. @@ -118,7 +118,7 @@ Please look into [this document](messages/invalid_no_account_number/README.md) f #### Messages with invalid format - missing cluster name -These messages should be rejected by *Insights Results Writer* and also by *CCS +These messages should be rejected by *Insights Results Writer* and also by *CCX Notification Writer* services as the `cluster_name` attribute is missing. These messages are stored in `messages/invalid_no_cluster_name/` subdirectory. @@ -129,7 +129,7 @@ Please look into [this document](messages/invalid_no_cluster_name/README.md) for #### Messages with invalid format - missing last checked timestamp -These messages should be rejected by *Insights Results Writer* and also by *CCS +These messages should be rejected by *Insights Results Writer* and also by *CCX Notification Writer* services as the `last_checked` attribute is missing. These messages are stored in `messages/invalid_no_last_checked/` subdirectory. @@ -140,7 +140,7 @@ Please look into [this document](messages/invalid_no_last_checked/README.md) for #### Messages with invalid format - missing organization ID -These messages should be rejected by *Insights Results Writer* and also by *CCS +These messages should be rejected by *Insights Results Writer* and also by *CCX Notification Writer* services as the `org_id` attribute is missing. These messages are stored in `messages/invalid_no_organization_id/` subdirectory. @@ -151,7 +151,7 @@ Please look into [this document](messages/invalid_no_organization_id/README.md) #### Messages with invalid format - missing version info -These messages should be rejected by *Insights Results Writer* and also by *CCS +These messages should be rejected by *Insights Results Writer* and also by *CCX Notification Writer* services as the `version` attribute is missing. These messages are stored in `messages/invalid_no_version/` subdirectory. @@ -162,7 +162,7 @@ Please look into [this document](messages/invalid_no_version/README.md) for deta #### Messages with invalid format - missing report -These messages should be rejected by *Insights Results Writer* and also by *CCS +These messages should be rejected by *Insights Results Writer* and also by *CCX Notification Writer* services as the whole report is missing (just other attributes are there). These messages are stored in `messages/invalid_no_report/` subdirectory.