From 8a4b4ff5e1a42f4ecb888af4848f325a931aa2be Mon Sep 17 00:00:00 2001 From: Brandon Schneider Date: Thu, 14 Nov 2024 14:44:32 -0600 Subject: [PATCH 1/3] Trigger build From 16c4ef7dc7de174284e899dff093dc41ef1daa54 Mon Sep 17 00:00:00 2001 From: Brandon Schneider Date: Thu, 14 Nov 2024 16:09:00 -0600 Subject: [PATCH 2/3] To see if this test failure is a race condition --- internal/api/tests/public/middleware_test.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/internal/api/tests/public/middleware_test.go b/internal/api/tests/public/middleware_test.go index a8e78ee5..7db8e025 100644 --- a/internal/api/tests/public/middleware_test.go +++ b/internal/api/tests/public/middleware_test.go @@ -6,6 +6,7 @@ import ( "io/ioutil" "net/http" "playbook-dispatcher/internal/common/utils/test" + "time" . "github.com/onsi/ginkgo" . "github.com/onsi/gomega" @@ -17,6 +18,8 @@ var _ = Describe("Middleware", func() { It("attaches request id to the response", func() { const requestId = "33ee136c-da81-4a68-953c-c22bdd096d30" + // For schmits and giggles to see if it's a race condition + time.Sleep(2 * time.Second) req, err := http.NewRequest(http.MethodGet, "http://localhost:9002/api/playbook-dispatcher/v1/runs", nil) Expect(err).ToNot(HaveOccurred()) From d130cfa38e998d1df850fe00e021dbadc01b19ea Mon Sep 17 00:00:00 2001 From: Brandon Schneider Date: Fri, 15 Nov 2024 12:44:31 -0600 Subject: [PATCH 3/3] Revert "To see if this test failure is a race condition" This reverts commit 16c4ef7dc7de174284e899dff093dc41ef1daa54. --- internal/api/tests/public/middleware_test.go | 3 --- 1 file changed, 3 deletions(-) diff --git a/internal/api/tests/public/middleware_test.go b/internal/api/tests/public/middleware_test.go index 7db8e025..a8e78ee5 100644 --- a/internal/api/tests/public/middleware_test.go +++ b/internal/api/tests/public/middleware_test.go @@ -6,7 +6,6 @@ import ( "io/ioutil" "net/http" "playbook-dispatcher/internal/common/utils/test" - "time" . "github.com/onsi/ginkgo" . "github.com/onsi/gomega" @@ -18,8 +17,6 @@ var _ = Describe("Middleware", func() { It("attaches request id to the response", func() { const requestId = "33ee136c-da81-4a68-953c-c22bdd096d30" - // For schmits and giggles to see if it's a race condition - time.Sleep(2 * time.Second) req, err := http.NewRequest(http.MethodGet, "http://localhost:9002/api/playbook-dispatcher/v1/runs", nil) Expect(err).ToNot(HaveOccurred())