Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mypy type hints #57

Open
dacevedo12 opened this issue Jul 4, 2024 · 2 comments
Open

mypy type hints #57

dacevedo12 opened this issue Jul 4, 2024 · 2 comments
Labels

Comments

@dacevedo12
Copy link

would be nice to have type hints added to the library

mypy currently complains due to cvss: module is installed, but missing library stubs or py.typed marker

https://peps.python.org/pep-0484/

@skontar skontar added enhancement good first issue Good for newcomers labels Jul 8, 2024
@jobselko
Copy link
Collaborator

jobselko commented Jul 8, 2024

Before supporting type hints, we should also consider dropping support for Python 2.7 to ease the potential work.

Since the function annotation syntax was introduced in Python 3.5, we would have to use comments to be compatible with Python 2.7, see https://peps.python.org/pep-0484/#suggested-syntax-for-python-2-7-and-straddling-code.

@skontar
Copy link
Collaborator

skontar commented Sep 7, 2024

@jobselko Python 2.7 support can be dropped now, as it is no longer supported, even by Red Hat (EOL June 2024).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants