Skip to content

Commit

Permalink
Update bigstore version 2 support flag to be a boolean option in comm… (
Browse files Browse the repository at this point in the history
#107)

* Update bigstore version 2 support flag to be a boolean option in command line and None as default
  • Loading branch information
eranhd authored Nov 24, 2024
1 parent 02cb985 commit 06c5c8c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion RAMP/ramp.py
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ def unpack(bundle):
@click.option('--redis-min-version', '-r', 'min_redis_version', default=None, help='redis minimum version')
@click.option('--redis-pack-min-version', '-R', 'min_redis_pack_version', default=None, help='redis pack minimum version')
@click.option('--redis-compatible-version', '-cr', 'compatible_redis_version', default=None, help='redis compatible version')
@click.option('--bigstore-version-2-support', 'bigstore_version_2_support', default=False, help='This module supports RofV2')
@click.option('--bigstore-version-2-support', 'bigstore_version_2_support', is_flag=True, default=None, help='This module supports RofV2')
@click.option('--config-command', '-cc', default=None, help='command used to configure module args at runtime')
@click.option('--os', '-O', default=None, help='build target OS (Darwin/Linux)')
@click.option('--capabilities', '-C', callback=comma_seperated_to_list, help='comma separated list of module capabilities')
Expand Down
2 changes: 1 addition & 1 deletion test.py
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ def test_bundle_from_cmd():
'-d', display_name, '-b', capability_name, '-n', module_name,
'-h', homepage, '-l', _license, '-c', command_line_args,
'-r', min_redis_version, '-R', min_redis_pack_version, '-cr', compatible_redis_version,
'--bigstore-version-2-support', bigstore_version_2_support,
'--bigstore-version-2-support',
'-C', ','.join([cap['name'] for cap in MODULE_CAPABILITIES]),
'-o', BUNDLE_ZIP_FILE, '-cc', CONFIG_COMMAND, '-E', 'graph.bulk',
'-E', 'graph.BULK',
Expand Down

0 comments on commit 06c5c8c

Please sign in to comment.