Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider migrating away from the use of "refresh_token_expires_at" #15

Open
pcurtisrab opened this issue Oct 13, 2020 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@pcurtisrab
Copy link
Contributor

Currently Dr. G is using the refresh_token_expires_at claim to capture the expiry date of the refresh token. The alternative is to use the exp value from the token introspection endpoint.

While this has the advantage of being provided in the id_token response (negating the need for a call to the introspection endpoint), it has the disadvantage of being contentious from a standards point of view. In the future there may be Data Holder implementations that take issue with the request for refresh_token_expires_at.

An even simpler alternative is to not check the introspection endpoint either, and simply assume that the refresh token expires in 28 days or the end of the sharing duration (whichever is earlier)

@pcurtisrab pcurtisrab added the enhancement New feature or request label Oct 13, 2020
@pcurtisrab
Copy link
Contributor Author

We should probably also remove refresh_token_expires_at from the default list of "mandatory" claims for the id_token. Given it's mandatory in one place but not in the other, this could have unpredictable results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant