Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: move lint out of build #1255

Merged
merged 1 commit into from
Nov 17, 2023
Merged

ci: move lint out of build #1255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 28 additions & 26 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,6 @@ jobs:
key: yarn-packages-{{ checksum "yarn.lock" }}
paths:
- ~/.cache/yarn
- run:
name: Verify format
command: yarn format:check
- run:
name: Verify lint
command: yarn lint:check
- run:
name: Build types
command: yarn workspace @requestnetwork/types run build
Expand All @@ -102,14 +96,21 @@ jobs:

- persist_to_workspace:
root: *working_directory
paths: .
lint-package-json:
paths:
- ./
Comment on lines +99 to +100
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just remove a warning from the json schema

lint:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename job to match what it does

docker:
- *node_image
working_directory: *working_directory
steps:
- attach_workspace:
at: *working_directory
- run:
name: Verify format
command: yarn format:check
- run:
name: Verify lint
command: yarn lint:check
Comment on lines +108 to +113
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main change

- run:
name: 'lint package.json files'
command: 'yarn run packageJsonLint'
Expand Down Expand Up @@ -591,7 +592,7 @@ workflows:
build-and-test:
jobs:
- build
- lint-package-json:
- lint:
requires:
- build
# Test
Expand Down Expand Up @@ -659,44 +660,48 @@ workflows:
# Publish the code coverage
- publish-coverage:
requires:
- test-request-client
- lint
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add lint, integration-test and smart-contracts which were missing
sort all tests

- test-advanced-logic
- test-currency
- test-data-access
- test-data-format
- test-transaction-manager
- test-ethereum-storage
- test-request-logic
- test-advanced-logic
- test-epk-signature
- test-web3-signature
- test-epk-decryption
- test-request-node
- test-utils
- test-currency
- test-epk-signature
- test-ethereum-storage
- test-integration-test
- test-multi-format
- test-payment-detection
- test-payment-processor
- test-request-client
- test-request-logic
- test-request-node
- test-smart-contracts
- test-transaction-manager
- test-utils
- test-web3-signature

# Release a next version package everytime we merge to master
- next-release:
requires:
- lint
- test-advanced-logic
- test-currency
- test-data-access
- test-data-format
- test-epk-decryption
- test-epk-signature
- test-ethereum-storage
- test-integration-test
- test-smart-contracts
- test-multi-format
- test-payment-detection
- test-payment-processor
- test-request-client
- test-request-logic
- test-request-node
- test-smart-contracts
- test-transaction-manager
- test-utils
- test-currency
- test-web3-signature
- test-payment-detection
- test-payment-processor
context: protocol-release
filters:
branches:
Expand All @@ -714,9 +719,6 @@ workflows:
- master
jobs:
- build
- lint-package-json:
requires:
- build
Comment on lines -717 to -719
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary in nighly build

- test-nightly:
requires:
- build
Loading