From 2f38e956c7563092554469a8285d80ec23f7fd36 Mon Sep 17 00:00:00 2001 From: Wes Copeland Date: Sun, 25 Feb 2024 17:24:48 -0500 Subject: [PATCH] ci: run on PRs (#78) --- .github/ISSUE_TEMPLATE/config.yml | 18 ++++----- .github/workflows/main.yml | 9 ++++- package.json | 15 +------- vitest.config.ts | 6 +-- yarn.lock | 61 ++----------------------------- 5 files changed, 24 insertions(+), 85 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml index 9a1eef5..b186a4f 100644 --- a/.github/ISSUE_TEMPLATE/config.yml +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -1,11 +1,11 @@ blank_issues_enabled: false contact_links: - - name: Ask a question - url: https://github.com/RetroAchievements/api-js/discussions/new?category=q-a - about: Ask the community for help - - name: Request a feature - url: https://github.com/RetroAchievements/api-js/discussions/new?category=ideas - about: Share ideas for new features - - name: Report a bug - url: https://github.com/RetroAchievements/api-js/issues/new - about: Report a reproducable bug + - name: Ask a question + url: https://github.com/RetroAchievements/api-js/discussions/new?category=q-a + about: Ask the community for help + - name: Request a feature + url: https://github.com/RetroAchievements/api-js/discussions/new?category=ideas + about: Share ideas for new features + - name: Report a bug + url: https://github.com/RetroAchievements/api-js/issues/new + about: Report a reproducable bug diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 05450c5..b670133 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -1,5 +1,12 @@ name: CI -on: [push] + +on: + push: + branches: + - main + pull_request: + types: [opened, synchronize, reopened] + jobs: build: name: Build, lint, and test on Node ${{ matrix.node }} and ${{ matrix.os }} diff --git a/package.json b/package.json index 96393cd..3a00bca 100644 --- a/package.json +++ b/package.json @@ -41,8 +41,7 @@ "test": "vitest run", "test:watch": "vitest", "test:coverage": "vitest run --coverage", - "verify": "yarn format:check && yarn lint && yarn test:coverage && yarn build && yarn size", - "size": "size-limit", + "verify": "yarn format:check && yarn lint && yarn test:coverage && yarn build", "start": "microbundle watch" }, "peerDependencies": {}, @@ -50,7 +49,6 @@ "@commitlint/cli": "^17.4.2", "@commitlint/config-conventional": "^17.4.2", "@digitak/esrun": "^3.2.19", - "@size-limit/preset-small-lib": "^8.1.2", "@tsconfig/recommended": "^1.0.2", "@typescript-eslint/eslint-plugin": "^6.9.1", "@typescript-eslint/parser": "^6.9.1", @@ -69,7 +67,6 @@ "msw": "^2.0.3", "prettier": "2.8.3", "pretty-quick": "3.1.3", - "size-limit": "^8.1.2", "tslib": "^2.6.2", "type-fest": "^4.6.0", "typescript": "^5.2.2", @@ -77,16 +74,6 @@ "vite": "^4.5.0", "vitest": "^0.34.6" }, - "size-limit": [ - { - "path": "dist/api.cjs.production.min.js", - "limit": "10 KB" - }, - { - "path": "dist/api.esm.js", - "limit": "10 KB" - } - ], "husky": { "hooks": { "pre-commit": "pretty-quick --staged && yarn lint", diff --git a/vitest.config.ts b/vitest.config.ts index a2cdf8e..41548b8 100644 --- a/vitest.config.ts +++ b/vitest.config.ts @@ -25,10 +25,10 @@ export default defineConfig({ "**/test/**", "**/__playground.ts" ], - statements: 100, - branches: 100, + statements: 95, + branches: 80, functions: 100, - lines: 100 + lines: 95 } } }); diff --git a/yarn.lock b/yarn.lock index 15b2c54..9fcc1a7 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1742,30 +1742,6 @@ resolved "https://registry.yarnpkg.com/@sinclair/typebox/-/typebox-0.27.8.tgz#6667fac16c436b5434a387a34dedb013198f6e6e" integrity sha512-+Fj43pSMwJs4KRrH/938Uf+uAELIgVBmQzg/q1YG10djyfA3TnrU8N8XzqCh/okZdszqBQTZf96idMfE5lnwTA== -"@size-limit/esbuild@8.2.6": - version "8.2.6" - resolved "https://registry.yarnpkg.com/@size-limit/esbuild/-/esbuild-8.2.6.tgz#81e4d38b94d678a423e6b1de29cafde53cde306e" - integrity sha512-a4c8xVDuDMYw5jF655ADjQDluw3jGPPYer6UJock5rSnUlWnIbmT/Ohud7gJGq5gqyLUQOCrBD7NB3g+mlhj4g== - dependencies: - esbuild "^0.18.6" - nanoid "^3.3.6" - -"@size-limit/file@8.2.6": - version "8.2.6" - resolved "https://registry.yarnpkg.com/@size-limit/file/-/file-8.2.6.tgz#0e17045a0fa8009fc787c85e3c09f611316f908c" - integrity sha512-B7ayjxiJsbtXdIIWazJkB5gezi5WBMecdHTFPMDhI3NwEML1RVvUjAkrb1mPAAkIpt2LVHPnhdCUHjqDdjugwg== - dependencies: - semver "7.5.3" - -"@size-limit/preset-small-lib@^8.1.2": - version "8.2.6" - resolved "https://registry.yarnpkg.com/@size-limit/preset-small-lib/-/preset-small-lib-8.2.6.tgz#d30399e07cb9b2bb0ee0d8525076ed6a25f52075" - integrity sha512-roanEuscDaaXDsT5Cg9agMbmsQVlMr66eRg3AwT2o4vE7WFLR8Z42p0AHZiwucW1nGpCxAh8E08Qa/yyVuj5nA== - dependencies: - "@size-limit/esbuild" "8.2.6" - "@size-limit/file" "8.2.6" - size-limit "8.2.6" - "@surma/rollup-plugin-off-main-thread@^2.2.2": version "2.2.3" resolved "https://registry.yarnpkg.com/@surma/rollup-plugin-off-main-thread/-/rollup-plugin-off-main-thread-2.2.3.tgz#ee34985952ca21558ab0d952f00298ad2190c053" @@ -2417,11 +2393,6 @@ builtin-modules@^3.1.0, builtin-modules@^3.3.0: resolved "https://registry.yarnpkg.com/builtin-modules/-/builtin-modules-3.3.0.tgz#cae62812b89801e9656336e46223e030386be7b6" integrity sha512-zhaCDicdLuWN5UbN5IMnFqNMhNfo919sH85y2/ea+5Yg9TsTkeZxpL+JLbp6cgYFS4sRLp3YV4S6yDuqVWHYOw== -bytes-iec@^3.1.1: - version "3.1.1" - resolved "https://registry.yarnpkg.com/bytes-iec/-/bytes-iec-3.1.1.tgz#94cd36bf95c2c22a82002c247df8772d1d591083" - integrity sha512-fey6+4jDK7TFtFg/klGSvNKJctyU7n2aQdnM+CO0ruLPbqqMOM8Tio0Pc+deqUeVKX1tL5DQep1zQ7+37aTAsA== - cac@^6.7.14: version "6.7.14" resolved "https://registry.yarnpkg.com/cac/-/cac-6.7.14.tgz#804e1e6f506ee363cb0e3ccbb09cad5dd9870959" @@ -2541,7 +2512,7 @@ check-error@^1.0.3: dependencies: get-func-name "^2.0.2" -chokidar@^3.4.2, chokidar@^3.5.1, chokidar@^3.5.3: +chokidar@^3.4.2, chokidar@^3.5.1: version "3.5.3" resolved "https://registry.yarnpkg.com/chokidar/-/chokidar-3.5.3.tgz#1cf37c8707b932bd1af1ae22c0432e2acd1903bd" integrity sha512-Dr3sfKRP6oTcjf2JmUmFJfeVMvXBdegxB0iVQ5eb2V10uFJUCAS8OByZdVAyVb8xXNz3GjjTgj9kLWsZTqE6kw== @@ -3225,7 +3196,7 @@ esbuild@^0.17.4: "@esbuild/win32-ia32" "0.17.19" "@esbuild/win32-x64" "0.17.19" -esbuild@^0.18.10, esbuild@^0.18.6: +esbuild@^0.18.10: version "0.18.20" resolved "https://registry.yarnpkg.com/esbuild/-/esbuild-0.18.20.tgz#4709f5a34801b43b799ab7d6d82f7284a9b7a7a6" integrity sha512-ceqxoedUrcayh7Y7ZX6NdbbDzGROiyVBgC4PriJThBKSVPWnnFHZAkfI1lJT8QFkOwH4qOS2SJkS4wvpGl8BpA== @@ -4566,7 +4537,7 @@ levn@^0.4.1: prelude-ls "^1.2.1" type-check "~0.4.0" -lilconfig@^2.0.3, lilconfig@^2.0.5, lilconfig@^2.1.0: +lilconfig@^2.0.3, lilconfig@^2.0.5: version "2.1.0" resolved "https://registry.yarnpkg.com/lilconfig/-/lilconfig-2.1.0.tgz#78e23ac89ebb7e1bfbf25b18043de756548e7f52" integrity sha512-utWOt/GHzuUxnLKxB6dk81RoOeoNeHgbrXiuGk4yyF5qlRz+iIVWu56E2fqGHFrXz0QNUhLB/8nKqvRH66JKGQ== @@ -4968,13 +4939,6 @@ nanoid@^3.3.6: resolved "https://registry.yarnpkg.com/nanoid/-/nanoid-3.3.6.tgz#443380c856d6e9f9824267d960b4236ad583ea4c" integrity sha512-BGcqMMJuToF7i1rt+2PWSNVnWIkGCU78jBG3RxO/bZlnZPK2Cmi2QaffxGO/2RvWi9sL+FAiRiXMgsyxQ1DIDA== -nanospinner@^1.1.0: - version "1.1.0" - resolved "https://registry.yarnpkg.com/nanospinner/-/nanospinner-1.1.0.tgz#d17ff621cb1784b0a206b400da88a0ef6db39b97" - integrity sha512-yFvNYMig4AthKYfHFl1sLj7B2nkHL4lzdig4osvl9/LdGbXwrdFRoqBS98gsEsOakr0yH+r5NZ/1Y9gdVB8trA== - dependencies: - picocolors "^1.0.0" - natural-compare@^1.4.0: version "1.4.0" resolved "https://registry.yarnpkg.com/natural-compare/-/natural-compare-1.4.0.tgz#4abebfeed7541f2c27acfb29bdbbd15c8d5ba4f7" @@ -6023,13 +5987,6 @@ semver-regex@^3.1.2: resolved "https://registry.yarnpkg.com/semver/-/semver-5.7.2.tgz#48d55db737c3287cd4835e17fa13feace1c41ef8" integrity sha512-cBznnQ9KjJqU67B52RMC65CMarK2600WFnbkcaiwWq3xy/5haFJlshgnpjovMVJ+Hff49d8GEn0b87C5pDQ10g== -semver@7.5.3: - version "7.5.3" - resolved "https://registry.yarnpkg.com/semver/-/semver-7.5.3.tgz#161ce8c2c6b4b3bdca6caadc9fa3317a4c4fe88e" - integrity sha512-QBlUtyVk/5EeHbi7X0fw6liDZc7BBmEaSYn01fMU1OUYbf6GPsbTtd8WmnqbI20SeycoHSeiybkE/q1Q+qlThQ== - dependencies: - lru-cache "^6.0.0" - semver@7.5.4, semver@^7.3.4, semver@^7.5.3, semver@^7.5.4: version "7.5.4" resolved "https://registry.yarnpkg.com/semver/-/semver-7.5.4.tgz#483986ec4ed38e1c6c48c34894a9182dbff68a6e" @@ -6099,18 +6056,6 @@ signal-exit@^3.0.2, signal-exit@^3.0.3: resolved "https://registry.yarnpkg.com/signal-exit/-/signal-exit-3.0.7.tgz#a9a1767f8af84155114eaabd73f99273c8f59ad9" integrity sha512-wnD2ZE+l+SPC/uoS0vXeE9L1+0wuaMqKlfz9AMUo38JsyLSBWSFcHR1Rri62LZc12vLr1gb3jl7iwQhgwpAbGQ== -size-limit@8.2.6, size-limit@^8.1.2: - version "8.2.6" - resolved "https://registry.yarnpkg.com/size-limit/-/size-limit-8.2.6.tgz#e41dbc74a4d7fc13be72551b6ef31ea50007d18d" - integrity sha512-zpznim/tX/NegjoQuRKgWTF4XiB0cn2qt90uJzxYNTFAqexk4b94DOAkBD3TwhC6c3kw2r0KcnA5upziVMZqDg== - dependencies: - bytes-iec "^3.1.1" - chokidar "^3.5.3" - globby "^11.1.0" - lilconfig "^2.1.0" - nanospinner "^1.1.0" - picocolors "^1.0.0" - slash@^3.0.0: version "3.0.0" resolved "https://registry.yarnpkg.com/slash/-/slash-3.0.0.tgz#6539be870c165adbd5240220dbe361f1bc4d4634"