-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input Threshold for reduced background noise? #12
Comments
Helo, the way the VOIP is designed is so that you can put any effect you want on the mic bus before the VOIPInputCapture, but it doesnt look like godot has any gate effect and it doesnt work with CLAP plugins >: godotengine/godot-proposals#8426 basic noise gates are some of the easiest effects to code (as long as u are not expecting krisp quality) so I could try and make one for u in a separate repository, but it will be annoying since I'd have to get used to the godot way of making plugins |
It's okay, I'll look into it myself first. Thanks for the info though, I would not have thought about changing the bus structure! With finals almost done, I should have time soon to put some real work in |
https://github.com/marc-weber1/godot/tree/gate-sound-effect my hand slipped, |
Holy moly you move fast! I'll keep an eye on that to see how it goes! |
What's the problem? Why hasn't it been merged yet? |
idk i think they just forgot u can bug them if u want |
Until the pull request is merged there's this https://github.com/Visssarion/audio-gate. Seems to mostly use the same code but is implemented as an addon |
I've tried using this plugin, and it works great! However, I noticed there is no way to set an input threshold, and by default too much background noise for my liking is caught.
I don't know how speex and opus would handle this, but I would assume there is some way in _sample_buf_to_packet to have an input threshold value checked against to stop sending packets (or send empty packets?) if the maximum value doesn't exceed the input threshold.
I am suggesting this because I am right at the end of finals and can't implement this myself, and it is not a feature that can be easily implemented on the GDScript side of things.
The text was updated successfully, but these errors were encountered: