You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
The hf emrtd dump commands --dir argument does not accept absolute paths, which leads to broken paths. Instead of relative paths it would be good that the user supplied dir would be handled as an absolute path. This way the user can also use relative paths themselves.
To Reproduce
Steps to reproduce the behavior:
Run the proxmark client software: ./pm3
Run the following command: hf emrtd dump -m [REDACTED] --dir /home/sanduuz/this/is/an/absolute/path
Notice that saving files fail due to invalid path:
...
[=] ..
[=] Read EF_CardAccess , len 42
[!] ⚠️ file not found or locked `/home/sanduuz//home/sanduuz/this/is/an/absolute/path/EF_CardAccess.BIN`
[=] Authentication is enforced
[=] Switching to external authentication...
[=] External authentication with BAC successful.
...
Expected behavior
The path should be handled as an absolute path. This would mean that with the above command, the files should be saved under /home/sanduuz/this/is/an/absolute/path/ instead of /home/sanduuz//home/sanduuz/this/is/an/absolute/path/.
Additional context
I am not familiar with the codebase and styleguide (yet) so I won't butcher everything up by adding bad code. However, this might be a good point to start:
Describe the bug
The
hf emrtd dump
commands--dir
argument does not accept absolute paths, which leads to broken paths. Instead of relative paths it would be good that the user supplied dir would be handled as an absolute path. This way the user can also use relative paths themselves.To Reproduce
Steps to reproduce the behavior:
./pm3
hf emrtd dump -m [REDACTED] --dir /home/sanduuz/this/is/an/absolute/path
Expected behavior
The path should be handled as an absolute path. This would mean that with the above command, the files should be saved under
/home/sanduuz/this/is/an/absolute/path/
instead of/home/sanduuz//home/sanduuz/this/is/an/absolute/path/
.Version information:
uname -a
:Linux obsidian 6.1.0-17-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.69-1 (2023-12-30) x86_64 GNU/Linux
)hw version
andhw status
Additional context
I am not familiar with the codebase and styleguide (yet) so I won't butcher everything up by adding bad code. However, this might be a good point to start:
proxmark3/client/src/cmdhfemrtd.c
Lines 2192 to 2195 in dac0a39
The text was updated successfully, but these errors were encountered: