From 0b4496572913dbc4dfc64b64e577c9daf9fe9abc Mon Sep 17 00:00:00 2001 From: Rian8337 <52914632+Rian8337@users.noreply.github.com> Date: Sun, 15 Sep 2024 06:28:44 +0700 Subject: [PATCH] Fix buffer reading methods not being bound to `this` --- .../src/ReplayAnalyzer.ts | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/packages/osu-droid-replay-analyzer/src/ReplayAnalyzer.ts b/packages/osu-droid-replay-analyzer/src/ReplayAnalyzer.ts index 7f0aef7e..e71429ae 100644 --- a/packages/osu-droid-replay-analyzer/src/ReplayAnalyzer.ts +++ b/packages/osu-droid-replay-analyzer/src/ReplayAnalyzer.ts @@ -625,17 +625,13 @@ export class ReplayAnalyzer { time[j] >>= 2; if (id[j] !== MovementType.up) { - x[j] = ( - resultObject.replayVersion >= 5 - ? this.readFloat - : this.readShort - )(replayDataBuffer); - - y[j] = ( - resultObject.replayVersion >= 5 - ? this.readFloat - : this.readShort - )(replayDataBuffer); + if (resultObject.replayVersion >= 5) { + x[j] = this.readFloat(replayDataBuffer); + y[j] = this.readFloat(replayDataBuffer); + } else { + x[j] = this.readShort(replayDataBuffer); + y[j] = this.readShort(replayDataBuffer); + } } else { x[j] = -1; y[j] = -1;